Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of DataLoader and DataModule #383

Merged
merged 15 commits into from
Nov 27, 2024
Merged

Implementation of DataLoader and DataModule #383

merged 15 commits into from
Nov 27, 2024

Conversation

FilippoOlivo
Copy link

No description provided.

@FilippoOlivo FilippoOlivo marked this pull request as ready for review November 20, 2024 11:23
dario-coscia
dario-coscia requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the PR this is amazing 🚀 We can now run PINA on multiple gpus and nodes, very nice job! I added few updates which should be short, than we merge it in the 0.2

pina/domain/cartesian.py Outdated Show resolved Hide resolved
pina/problem/abstract_problem.py Outdated Show resolved Hide resolved
pina/trainer.py Outdated Show resolved Hide resolved
pina/trainer.py Outdated Show resolved Hide resolved
pina/trainer.py Outdated Show resolved Hide resolved
tests/test_dataset.py Outdated Show resolved Hide resolved
tutorials/tutorial5/tutorial.ipynb Outdated Show resolved Hide resolved
tests/test_solvers/test_pinn.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
pina/problem/inverse_problem.py Show resolved Hide resolved
@dario-coscia dario-coscia added the pr-to-fix Label for PR that needs modification label Nov 20, 2024
@FilippoOlivo FilippoOlivo changed the base branch from 0.2 to benchmark November 23, 2024 09:47
@FilippoOlivo FilippoOlivo changed the base branch from benchmark to 0.2 November 25, 2024 09:28
@dario-coscia dario-coscia self-requested a review November 27, 2024 14:59
@dario-coscia dario-coscia added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Nov 27, 2024
dario-coscia
dario-coscia approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dario-coscia dario-coscia merged commit 8f458d2 into mathLab:0.2 Nov 27, 2024
0 of 16 checks passed
@FilippoOlivo FilippoOlivo mentioned this pull request Nov 27, 2024
Merged
@FilippoOlivo FilippoOlivo mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dario-coscia dario-coscia dario-coscia approved these changes

Assignees

@dario-coscia dario-coscia

@FilippoOlivo FilippoOlivo

Labels
pr-to-review Label for PR that are ready to been reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FilippoOlivo @dario-coscia